remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-24 09:54:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix pks_and_rows_where() on views

Browse source 
The previous compound-pk-ordering commit switched pks_and_rows_where()
to Table-only properties, but the method is defined on Queryable and
views exposed it too - calling it on a View raised AttributeError.

Restored Queryable-safe logic, and stopped double-quoting the
synthesized rowid column: SQLite turns a double-quoted identifier that
does not resolve into a string literal, so on a view the generated
select "rowid" silently produced the string 'rowid' and a confusing
KeyError, where 3.x's [rowid] quoting raised OperationalError cleanly.

Refs https://github.com/simonw/sqlite-utils/issues/769#issuecomment-4900034150

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Simon Willison 2026-07-06 21:42:02 -07:00
commit 1ed95e4ad2
3 changed files with 38 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

21
sqlite_utils/db.py
View file

@ -2023,11 +2023,22 @@ class Queryable:
:param limit: Integer number of rows to limit to
:param offset: Integer for SQL offset
"""
column_names = [column.name for column in self.columns]
pks = self.pks
if self.use_rowid:
column_names.insert(0, "rowid")
select = ",".join(quote_identifier(column_name) for column_name in column_names)
# This method is defined on Queryable so it serves views too, which
# have no pks property - sort pk columns into declaration order here
pk_columns = sorted(
(column for column in self.columns if column.is_pk),
key=lambda column: column.is_pk,
)
pks = [column.name for column in pk_columns]
select_parts = [quote_identifier(column.name) for column in self.columns]
if not pks:
# rowid is left unquoted: it is not a real column, and SQLite
# turns a double-quoted identifier that does not resolve into a
# string literal - on a view that would silently select the
# string 'rowid' instead of raising an error
select_parts.insert(0, "rowid")
pks = ["rowid"]
select = ",".join(select_parts)
for row in self.rows_where(
select=select,
where=where,