Add --ignore to create-index as alias of --if-not-exists, refs #450

This commit is contained in:
Simon Willison 2022-07-15 15:25:49 -07:00
commit 2c77f4467e
3 changed files with 13 additions and 13 deletions

View file

@ -841,12 +841,12 @@ See :ref:`cli_create_index`.
sqlite-utils create-index chickens.db chickens -- -name
Options:
--name TEXT Explicit name for the new index
--unique Make this a unique index
--if-not-exists Ignore if index already exists
--analyze Run ANALYZE after creating the index
--load-extension TEXT SQLite extensions to load
-h, --help Show this message and exit.
--name TEXT Explicit name for the new index
--unique Make this a unique index
--if-not-exists, --ignore Ignore if index already exists
--analyze Run ANALYZE after creating the index
--load-extension TEXT SQLite extensions to load
-h, --help Show this message and exit.
enable-fts

View file

@ -539,6 +539,7 @@ def index_foreign_keys(path, load_extension):
@click.option("--unique", help="Make this a unique index", default=False, is_flag=True)
@click.option(
"--if-not-exists",
"--ignore",
help="Ignore if index already exists",
default=False,
is_flag=True,

View file

@ -214,13 +214,12 @@ def test_create_index(db_path):
] == db["Gosh2"].indexes
# Trying to create the same index should fail
assert 0 != CliRunner().invoke(cli.cli, create_index_unique_args).exit_code
# ... unless we use --if-not-exists
assert (
0
== CliRunner()
.invoke(cli.cli, create_index_unique_args + ["--if-not-exists"])
.exit_code
)
# ... unless we use --if-not-exists or --ignore
for option in ("--if-not-exists", "--ignore"):
assert (
CliRunner().invoke(cli.cli, create_index_unique_args + [option]).exit_code
== 0
)
def test_create_index_analyze(db_path):