remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-09-12 03:24:23 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix for REAL columns by CSV --detect-types

Browse source 
Refs https://github.com/simonw/sqlite-utils/issues/645#issuecomment-3568947189
This commit is contained in:
Simon Willison 2025-11-23 21:11:27 -08:00
commit 3b18b9e149
4 changed files with 26 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/cli-reference.rst
View file

@ -1142,7 +1142,7 @@ See :ref:`cli_add_column`.
::
Usage: sqlite-utils add-column [OPTIONS] PATH TABLE COL_NAME
[[integer|int|float|text|str|blob|bytes]]
[[integer|int|float|real|text|str|blob|bytes]]
Add a column to the specified table

2
sqlite_utils/cli.py
View file

@ -419,7 +419,7 @@ def dump(path, load_extension):
@click.argument(
"col_type",
type=click.Choice(
["integer", "int", "float", "text", "str", "blob", "bytes"],
["integer", "int", "float", "real", "text", "str", "blob", "bytes"],
case_sensitive=False,
),
required=False,

2
sqlite_utils/db.py
View file

@ -216,7 +216,7 @@ COLUMN_TYPE_MAPPING = {
"str": "TEXT",
"integer": "INTEGER",
"int": "INTEGER",
"float": "FLOAT",
"float": "REAL",
"real": "REAL",
"blob": "BLOB",
"bytes": "BLOB",

24
tests/test_cli.py
View file

@ -284,7 +284,7 @@ def test_create_index_desc(db_path):
"int",
'CREATE TABLE "dogs" (\n "name" TEXT\n, "integer" INTEGER)',
),
("float", "FLOAT", 'CREATE TABLE "dogs" (\n "name" TEXT\n, "float" FLOAT)'),
("float", "FLOAT", 'CREATE TABLE "dogs" (\n "name" TEXT\n, "float" REAL)'),
("blob", "blob", 'CREATE TABLE "dogs" (\n "name" TEXT\n, "blob" BLOB)'),
("blob", "BLOB", 'CREATE TABLE "dogs" (\n "name" TEXT\n, "blob" BLOB)'),
("blob", "bytes", 'CREATE TABLE "dogs" (\n "name" TEXT\n, "blob" BLOB)'),
@ -2240,6 +2240,28 @@ def test_upsert_detect_types(tmpdir, option):
]
def test_csv_detect_types_creates_real_columns(tmpdir):
"""Test that CSV import with --detect-types creates REAL columns for floats"""
db_path = str(tmpdir / "test.db")
data = "name,age,weight\nCleo,6,45.5\nDori,1,3.5"
result = CliRunner().invoke(
cli.cli,
["insert", db_path, "creatures", "-", "--csv", "--detect-types"],
catch_exceptions=False,
input=data,
)
assert result.exit_code == 0
db = Database(db_path)
# Check that the schema uses REAL for the weight column
assert db["creatures"].schema == (
'CREATE TABLE "creatures" (\n'
' "name" TEXT,\n'
' "age" INTEGER,\n'
' "weight" REAL\n'
")"
)
def test_integer_overflow_error(tmpdir):
db_path = str(tmpdir / "test.db")
result = CliRunner().invoke(