remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-09-10 02:24:22 +02:00
Code Issues Projects Releases Packages Wiki Activity

Refactor test for #149, spitting it from other rebuild test

Browse source 
Also refs #354
This commit is contained in:
Simon Willison 2021-12-10 16:56:50 -08:00
commit 3b2a7c0e5b
1 changed files with 4 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

30
tests/test_cli.py
View file

@ -556,8 +556,7 @@ def test_optimize(db_path, tables):
assert 0 == result.exit_code assert 0 == result.exit_code
@pytest.mark.parametrize("tables", ([], ["fts4_table"], ["fts5_table"])) def test_rebuild_fts_fixes_docsize_error(db_path):
def test_rebuild_fts(db_path, tables):
db = Database(db_path, recursive_triggers=False) db = Database(db_path, recursive_triggers=False)
records = [ records = [
{ {
@ -568,43 +567,22 @@ def test_rebuild_fts(db_path, tables):
for i in range(10000) for i in range(10000)
] ]
with db.conn: with db.conn:
db["fts4_table"].insert_all(records, pk="c1")
db["fts5_table"].insert_all(records, pk="c1") db["fts5_table"].insert_all(records, pk="c1")
db["fts4_table"].enable_fts(
["c1", "c2", "c3"], fts_version="FTS4", create_triggers=True
)
db["fts5_table"].enable_fts( db["fts5_table"].enable_fts(
["c1", "c2", "c3"], fts_version="FTS5", create_triggers=True ["c1", "c2", "c3"], fts_version="FTS5", create_triggers=True
) )
# Search should work # Search should work
assert list(db["fts4_table"].search("verb1"))
assert list(db["fts5_table"].search("verb1")) assert list(db["fts5_table"].search("verb1"))
# Deleting _fts_segments to break FTS4
with db.conn:
db["fts4_table_fts_segments"].delete_where()
# Now this should error:
with pytest.raises(sqlite3.DatabaseError):
list(db["fts4_table"].search("verb1"))
# Replicate docsize error from this issue for FTS5 # Replicate docsize error from this issue for FTS5
# https://github.com/simonw/sqlite-utils/issues/149 # https://github.com/simonw/sqlite-utils/issues/149
assert db["fts5_table_fts_docsize"].count == 10000 assert db["fts5_table_fts_docsize"].count == 10000
db["fts5_table"].insert_all(records, replace=True) db["fts5_table"].insert_all(records, replace=True)
assert db["fts5_table"].count == 10000 assert db["fts5_table"].count == 10000
assert db["fts5_table_fts_docsize"].count == 20000 assert db["fts5_table_fts_docsize"].count == 20000
# Running rebuild-fts should fix both issues # Running rebuild-fts should fix this
print(["rebuild-fts", db_path] + tables) result = CliRunner().invoke(cli.cli, ["rebuild-fts", db_path, "fts5_table"])
result = CliRunner().invoke(cli.cli, ["rebuild-fts", db_path] + tables)
assert 0 == result.exit_code assert 0 == result.exit_code
fixed_tables = tables or ["fts4_table", "fts5_table"] assert db["fts5_table_fts_docsize"].count == 10000
if "fts4_table" in fixed_tables:
assert list(db["fts4_table"].search("verb1"))
else:
with pytest.raises(sqlite3.DatabaseError):
list(db["fts4_table"].search("verb1"))
if "fts5_table" in fixed_tables:
assert db["fts5_table_fts_docsize"].count == 10000
else:
assert db["fts5_table_fts_docsize"].count == 20000
def test_insert_simple(tmpdir): def test_insert_simple(tmpdir):