remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-24 18:04:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

table.optimize() deletes junk docsize rows

Browse source 
Closes #153. Closes #149.
This commit is contained in:
Simon Willison 2020-09-07 14:16:13 -07:00
commit 3e87500e15
4 changed files with 34 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

20
tests/test_optimize.py Normal file
View file

@ -0,0 +1,20 @@
import pytest
from sqlite_utils import Database
import sqlite3
@pytest.mark.parametrize("fts_version", ["FTS4", "FTS5"])
def test_optimizes_removes_junk_docsize_rows(tmpdir, fts_version):
# Recreating https://github.com/simonw/sqlite-utils/issues/149
path = tmpdir / "test.db"
db = Database(str(path), recursive_triggers=False)
licenses = [{"key": "apache2", "name": "Apache 2"}, {"key": "bsd", "name": "BSD"}]
db["licenses"].insert_all(licenses, pk="key", replace=True)
db["licenses"].enable_fts(["name"], create_triggers=True, fts_version=fts_version)
assert db["licenses_fts_docsize"].count == 2
# Bug: insert with replace increases the number of rows in _docsize:
db["licenses"].insert_all(licenses, pk="key", replace=True)
assert db["licenses_fts_docsize"].count == 4
# Optimize should fix this:
db["licenses_fts"].optimize()
assert db["licenses_fts_docsize"].count == 2