From 40b6947255540b8cf0639b87824ea8568ec6863c Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Fri, 15 Jul 2022 15:20:26 -0700
Subject: [PATCH] enable-fts --replace option, refs #450

Also fixed up some sqlite3.OperationalError imports.
---
 docs/cli-reference.rst |  1 +
 sqlite_utils/cli.py    | 36 +++++++++++++++++++++++-------------
 tests/test_cli.py      | 25 +++++++++++++++++++++++++
 3 files changed, 49 insertions(+), 13 deletions(-)

diff --git a/docs/cli-reference.rst b/docs/cli-reference.rst
index 6ef7052..09eb0be 100644
--- a/docs/cli-reference.rst
+++ b/docs/cli-reference.rst
@@ -870,6 +870,7 @@ See :ref:`cli_fts`.
       --tokenize TEXT        Tokenizer to use, e.g. porter
       --create-triggers      Create triggers to update the FTS tables when the
                              parent table changes.
+      --replace              Replace existing FTS configuration if it exists
       --load-extension TEXT  SQLite extensions to load
       -h, --help             Show this message and exit.
 
diff --git a/sqlite_utils/cli.py b/sqlite_utils/cli.py
index 09e441c..cf00898 100644
--- a/sqlite_utils/cli.py
+++ b/sqlite_utils/cli.py
@@ -18,6 +18,7 @@ import sys
 import csv as csv_std
 import tabulate
 from .utils import (
+    OperationalError,
     _compile_code,
     chunks,
     file_progress,
@@ -345,7 +346,7 @@ def analyze(path, names):
                 db.analyze(name)
         else:
             db.analyze()
-    except sqlite3.OperationalError as e:
+    except OperationalError as e:
         raise click.ClickException(e)
 
 
@@ -598,9 +599,14 @@ def create_index(
     default=False,
     is_flag=True,
 )
+@click.option(
+    "--replace",
+    is_flag=True,
+    help="Replace existing FTS configuration if it exists",
+)
 @load_extension_option
 def enable_fts(
-    path, table, column, fts4, fts5, tokenize, create_triggers, load_extension
+    path, table, column, fts4, fts5, tokenize, create_triggers, replace, load_extension
 ):
     """Enable full-text search for specific table and columns"
 
@@ -618,12 +624,16 @@ def enable_fts(
 
     db = sqlite_utils.Database(path)
     _load_extensions(db, load_extension)
-    db[table].enable_fts(
-        column,
-        fts_version=fts_version,
-        tokenize=tokenize,
-        create_triggers=create_triggers,
-    )
+    try:
+        db[table].enable_fts(
+            column,
+            fts_version=fts_version,
+            tokenize=tokenize,
+            create_triggers=create_triggers,
+            replace=replace,
+        )
+    except OperationalError as ex:
+        raise click.ClickException(ex)
 
 
 @cli.command(name="populate-fts")
@@ -1024,7 +1034,7 @@ def insert_upsert_implementation(
         )
     except Exception as e:
         if (
-            isinstance(e, sqlite3.OperationalError)
+            isinstance(e, OperationalError)
             and e.args
             and "has no column named" in e.args[0]
         ):
@@ -1341,7 +1351,7 @@ def bulk(
             silent=False,
             bulk_sql=sql,
         )
-    except (sqlite3.OperationalError, sqlite3.IntegrityError) as e:
+    except (OperationalError, sqlite3.IntegrityError) as e:
         raise click.ClickException(str(e))
 
 
@@ -1507,7 +1517,7 @@ def drop_table(path, table, ignore, load_extension):
     _load_extensions(db, load_extension)
     try:
         db[table].drop(ignore=ignore)
-    except sqlite3.OperationalError:
+    except OperationalError:
         raise click.ClickException('Table "{}" does not exist'.format(table))
 
 
@@ -1577,7 +1587,7 @@ def drop_view(path, view, ignore, load_extension):
     _load_extensions(db, load_extension)
     try:
         db[view].drop(ignore=ignore)
-    except sqlite3.OperationalError:
+    except OperationalError:
         raise click.ClickException('View "{}" does not exist'.format(view))
 
 
@@ -1818,7 +1828,7 @@ def _execute_query(
     with db.conn:
         try:
             cursor = db.execute(sql, dict(param))
-        except sqlite3.OperationalError as e:
+        except OperationalError as e:
             raise click.ClickException(str(e))
         if cursor.description is None:
             # This was an update/insert
diff --git a/tests/test_cli.py b/tests/test_cli.py
index a2ce739..01cc9bb 100644
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -455,6 +455,31 @@ def test_enable_fts(db_path):
     db["http://example.com"].drop()
 
 
+def test_enable_fts_replace(db_path):
+    db = Database(db_path)
+    assert db["Gosh"].detect_fts() is None
+    result = CliRunner().invoke(
+        cli.cli, ["enable-fts", db_path, "Gosh", "c1", "--fts4"]
+    )
+    assert result.exit_code == 0
+    assert "Gosh_fts" == db["Gosh"].detect_fts()
+    assert db["Gosh_fts"].columns_dict == {"c1": str}
+
+    # This should throw an error
+    result2 = CliRunner().invoke(
+        cli.cli, ["enable-fts", db_path, "Gosh", "c1", "--fts4"]
+    )
+    assert result2.exit_code == 1
+    assert result2.output == "Error: table [Gosh_fts] already exists\n"
+
+    # This should work
+    result3 = CliRunner().invoke(
+        cli.cli, ["enable-fts", db_path, "Gosh", "c2", "--fts4", "--replace"]
+    )
+    assert result3.exit_code == 0
+    assert db["Gosh_fts"].columns_dict == {"c2": str}
+
+
 def test_enable_fts_with_triggers(db_path):
     Database(db_path)["Gosh"].insert_all([{"c1": "baz"}])
     exit_code = (