remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-24 01:44:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix ResourceWarning in sqlite-utils insert, refs #534

Browse source
This commit is contained in:
Simon Willison 2023-05-08 12:39:06 -07:00
commit 4fc2f12c88
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
sqlite_utils/cli.py
View file

@ -948,14 +948,15 @@ def insert_upsert_implementation(
# The --sniff option needs us to buffer the file to peek ahead
sniff_buffer = None
decoded_buffer = None
if sniff:
sniff_buffer = io.BufferedReader(file, buffer_size=4096)
decoded = io.TextIOWrapper(sniff_buffer, encoding=encoding)
decoded_buffer = io.TextIOWrapper(sniff_buffer, encoding=encoding)
else:
decoded = io.TextIOWrapper(file, encoding=encoding)
decoded_buffer = io.TextIOWrapper(file, encoding=encoding)
tracker = None
with file_progress(decoded, silent=silent) as decoded:
with file_progress(decoded_buffer, silent=silent) as decoded:
if csv or tsv:
if sniff:
# Read first 2048 bytes and use that to detect
@ -1079,6 +1080,12 @@ def insert_upsert_implementation(
if tracker is not None:
db[table].transform(types=tracker.types)
# Clean up open file-like objects
if sniff_buffer:
sniff_buffer.close()
if decoded_buffer:
decoded_buffer.close()
def _find_variables(tb, vars):
to_find = list(vars)