remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-09-25 19:34:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix issue #1: transform-fails-to-drop-column-if-table-is-part

Browse source
This commit is contained in:
libra-exla[bot] 2026-06-02 00:11:23 +00:00
commit 52fc6fc115
2 changed files with 74 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

26
sqlite_utils/db.py
View file

@ -1905,6 +1905,17 @@ class Table(Queryable):
column_order=column_order,
keep_table=keep_table,
)
views = self.db.execute(
"select name, sql from sqlite_master where type = 'view' "
"and sql is not null order by rowid"
).fetchall()
view_triggers = []
if views:
view_triggers = self.db.execute(
"select name, sql from sqlite_master where type = 'trigger' "
"and sql is not null and tbl_name in "
"(select name from sqlite_master where type = 'view') order by rowid"
).fetchall()
pragma_foreign_keys_was_on = self.db.execute("PRAGMA foreign_keys").fetchone()[
0
]
@ -1912,11 +1923,26 @@ class Table(Queryable):
if pragma_foreign_keys_was_on:
self.db.execute("PRAGMA foreign_keys=0;")
with self.db.conn:
if views and not self.db.conn.in_transaction:
self.db.execute("BEGIN;")
for view_name, _ in views:
self.db.execute("DROP VIEW {}".format(quote_identifier(view_name)))
for sql in sqls:
self.db.execute(sql)
# Run the foreign_key_check before we commit
if pragma_foreign_keys_was_on:
self.db.execute("PRAGMA foreign_key_check;")
for view_name, view_sql in views:
try:
self.db.execute(view_sql)
except sqlite3.OperationalError as e:
raise TransformError(
f"View '{view_name}' could not be recreated after transforming table '{self.name}'. "
"It may reference columns that were dropped or renamed. "
"You must recreate this view manually."
) from e
for _, trigger_sql in view_triggers:
self.db.execute(trigger_sql)
finally:
if pragma_foreign_keys_was_on:
self.db.execute("PRAGMA foreign_keys=1;")