remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-28 11:54:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

Better support check for deterministic=True, closes #425

Browse source 
Bug first discovered in #421
This commit is contained in:
Simon Willison 2022-04-13 15:31:37 -07:00
commit 6f3ae864f1
2 changed files with 39 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

19
sqlite_utils/db.py
View file

@ -392,13 +392,18 @@ class Database:
if not replace and (name, arity) in self._registered_functions:
return fn
kwargs = {}
if (
deterministic
and sys.version_info >= (3, 8)
and self.sqlite_version >= (3, 8, 3)
):
kwargs["deterministic"] = True
self.conn.create_function(name, arity, fn, **kwargs)
registered = False
if deterministic:
# Try this, but fall back if sqlite3.NotSupportedError
try:
self.conn.create_function(
name, arity, fn, **dict(kwargs, deterministic=True)
)
registered = True
except sqlite3.NotSupportedError:
pass
if not registered:
self.conn.create_function(name, arity, fn, **kwargs)
self._registered_functions.add((name, arity))
return fn