remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-09-28 12:54:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Make least_common/most_common order dependable for tests

Browse source
This commit is contained in:
Simon Willison 2020-12-12 23:18:49 -08:00
commit 95a966bb62
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
sqlite_utils/db.py
View file

@ -1979,8 +1979,8 @@ class Table(Queryable):
most_common = [ most_common = [
(truncate(r[0]), r[1]) (truncate(r[0]), r[1])
for r in db.execute( for r in db.execute(
"select [{}], count(*) from [{}] group by [{}] order by count(*) desc limit {}".format( "select [{}], count(*) from [{}] group by [{}] order by count(*) desc, [{}] limit {}".format(
column, table, column, common_limit column, table, column, column, common_limit
) )
).fetchall() ).fetchall()
] ]
@ -1992,8 +1992,8 @@ class Table(Queryable):
least_common = [ least_common = [
(truncate(r[0]), r[1]) (truncate(r[0]), r[1])
for r in db.execute( for r in db.execute(
"select [{}], count(*) from [{}] group by [{}] order by count(*) limit {}".format( "select [{}], count(*) from [{}] group by [{}] order by count(*), [{}] desc limit {}".format(
column, table, column, common_limit column, table, column, column, common_limit
) )
).fetchall() ).fetchall()
] ]

4
tests/test_analyze_tables.py
View file

@ -51,8 +51,8 @@ def db_to_analyze(fresh_db):
num_null=0, num_null=0,
num_blank=0, num_blank=0,
num_distinct=4, num_distinct=4,
most_common=[("Joan", 3), ("Terry...", 2)], most_common=[("Joan", 3), ("Kumar", 2)],
least_common=[("Anne", 1), ("Kumar", 2)], least_common=[("Anne", 1), ("Terry...", 2)],
), ),
), ),
( (