remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-08-01 23:14:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Split out _iter_complete_sql_statements

Browse source 
To make it clearer why we are avoiding executescript()
This commit is contained in:
Simon Willison 2026-06-21 10:18:25 -07:00
commit a65df4cc69
2 changed files with 57 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

26
sqlite_utils/db.py
View file

@ -196,6 +196,19 @@ DEFAULT = Default()
Tracer = Callable[[str, Optional[Union[Sequence[Any], Dict[str, Any]]]], None]
def _iter_complete_sql_statements(sql: str) -> Generator[str, None, None]:
statement = []
for char in sql:
statement.append(char)
statement_sql = "".join(statement).strip()
if statement_sql and sqlite3.complete_statement(statement_sql):
yield statement_sql
statement = []
statement_sql = "".join(statement).strip()
if statement_sql:
yield statement_sql
COLUMN_TYPE_MAPPING: Dict[Any, str] = {
float: "REAL",
int: "INTEGER",
@ -618,16 +631,9 @@ class Database:
def _executescript(self, sql: str) -> sqlite3.Cursor:
if self.conn.in_transaction:
cursor = self.conn.cursor()
statement = []
for char in sql:
statement.append(char)
statement_sql = "".join(statement).strip()
if statement_sql and sqlite3.complete_statement(statement_sql):
cursor.execute(statement_sql)
statement = []
statement_sql = "".join(statement).strip()
if statement_sql:
cursor.execute(statement_sql)
# avoid sqlite3.executescript()'s implicit commit:
for statement in _iter_complete_sql_statements(sql):
cursor.execute(statement)
return cursor
return self.conn.executescript(sql)