From bf15acde88d4d2f59a00595f699e49c66673f7f5 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Thu, 24 Sep 2020 07:53:30 -0700 Subject: [PATCH] Removed unnecessary progress bar, refs #172 --- sqlite_utils/cli.py | 16 +--------------- sqlite_utils/db.py | 2 +- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/sqlite_utils/cli.py b/sqlite_utils/cli.py index 9ff56f5..7948d27 100644 --- a/sqlite_utils/cli.py +++ b/sqlite_utils/cli.py @@ -1006,12 +1006,6 @@ def transform( multiple=True, help="Rename this column in extracted table", ) -@click.option( - "-s", - "--silent", - is_flag=True, - help="Don't show progress bar", -) def extract( path, table, @@ -1019,7 +1013,6 @@ def extract( other_table, fk_column, rename, - silent, ): "Extract one or more columns into a separate table" db = sqlite_utils.Database(path) @@ -1029,14 +1022,7 @@ def extract( fk_column=fk_column, rename=dict(rename), ) - if silent: - db[table].extract(**kwargs) - else: - with click.progressbar( - length=db[table].count, label="Extracting columns" - ) as bar: - kwargs["progress"] = bar.update - db[table].extract(**kwargs) + db[table].extract(**kwargs) @cli.command(name="insert-files") diff --git a/sqlite_utils/db.py b/sqlite_utils/db.py index 385af55..d4ebf22 100644 --- a/sqlite_utils/db.py +++ b/sqlite_utils/db.py @@ -872,7 +872,7 @@ class Table(Queryable): ) return sqls - def extract(self, columns, table=None, fk_column=None, rename=None, progress=None): + def extract(self, columns, table=None, fk_column=None, rename=None): rename = rename or {} if isinstance(columns, str): columns = [columns]