remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-25 18:34:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

Test for analyze-tables --save

Browse source
This commit is contained in:
Simon Willison 2020-12-12 20:51:40 -08:00
commit c0d21956bc
2 changed files with 49 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
sqlite_utils/cli.py
View file

@ -1396,9 +1396,10 @@ def analyze_tables(
column, total_rows=table_counts[table]
)
if save:
db["_analyze_tables"].insert(
db["_analyze_tables_"].insert(
column_details._asdict(), pk=("table", "column"), replace=True
)
click.echo("{}/{}: {}".format(i + 1, len(todo), column_details))

50
tests/test_analyze_tables.py
View file

@ -1,4 +1,4 @@
from sqlite_utils.db import ForeignKey, ColumnDetails
from sqlite_utils.db import Database, ForeignKey, ColumnDetails
from sqlite_utils import cli
from sqlite_utils.utils import OperationalError
from click.testing import CliRunner
@ -74,11 +74,16 @@ def test_analyze_column(db_to_analyze, column, expected):
assert db_to_analyze["stuff"].analyze_column(column, common_limit=2) == expected
def test_analyze_table(db_to_analyze, tmpdir):
@pytest.fixture
def db_to_analyze_path(db_to_analyze, tmpdir):
path = str(tmpdir / "test.db")
db = sqlite3.connect(path)
db.executescript("\n".join(db_to_analyze.conn.iterdump()))
result = CliRunner().invoke(cli.cli, ["analyze-tables", path])
return path
def test_analyze_table(db_to_analyze_path):
result = CliRunner().invoke(cli.cli, ["analyze-tables", db_to_analyze_path])
assert (
result.output.strip()
== textwrap.dedent(
@ -89,3 +94,42 @@ def test_analyze_table(db_to_analyze, tmpdir):
"""
).strip()
)
def test_analyze_table_save(db_to_analyze_path):
result = CliRunner().invoke(
cli.cli, ["analyze-tables", db_to_analyze_path, "--save"]
)
rows = list(Database(db_to_analyze_path)["_analyze_tables_"].rows)
assert rows == [
{
"table": "stuff",
"column": "id",
"total_rows": 8,
"num_null": 0,
"num_blank": 0,
"num_distinct": 8,
"most_common": None,
"least_common": None,
},
{
"table": "stuff",
"column": "owner",
"total_rows": 8,
"num_null": 0,
"num_blank": 0,
"num_distinct": 4,
"most_common": '[["Joan", 3], ["Terry", 2], ["Kumar", 2], ["Anne", 1]]',
"least_common": None,
},
{
"table": "stuff",
"column": "size",
"total_rows": 8,
"num_null": 0,
"num_blank": 0,
"num_distinct": 2,
"most_common": "[[5, 5], [4, 3]]",
"least_common": None,
},
]