diff --git a/sqlite_utils/cli.py b/sqlite_utils/cli.py index d45f1c5..0b51517 100644 --- a/sqlite_utils/cli.py +++ b/sqlite_utils/cli.py @@ -266,12 +266,12 @@ def create_index(path, table, column, name, unique, if_not_exists): @click.option("--fts4", help="Use FTS4", default=False, is_flag=True) @click.option("--fts5", help="Use FTS5", default=False, is_flag=True) @click.option( - "--create-update-triggers", + "--create-triggers", help="Create triggers to update the FTS tables when the parent table changes.", default=False, is_flag=True, ) -def enable_fts(path, table, column, fts4, fts5, create_update_triggers): +def enable_fts(path, table, column, fts4, fts5, create_triggers): "Enable FTS for specific table and columns" fts_version = "FTS5" if fts4 and fts5: @@ -282,7 +282,7 @@ def enable_fts(path, table, column, fts4, fts5, create_update_triggers): db = sqlite_utils.Database(path) db[table].enable_fts( - column, fts_version=fts_version, create_update_triggers=create_update_triggers + column, fts_version=fts_version, create_triggers=create_triggers ) diff --git a/sqlite_utils/db.py b/sqlite_utils/db.py index 056756a..6f08ca9 100644 --- a/sqlite_utils/db.py +++ b/sqlite_utils/db.py @@ -710,7 +710,7 @@ class Table(Queryable): ) self.db.add_foreign_keys([(self.name, column, other_table, other_column)]) - def enable_fts(self, columns, fts_version="FTS5", create_update_triggers=False): + def enable_fts(self, columns, fts_version="FTS5", create_triggers=False): "Enables FTS on the specified columns." sql = """ CREATE VIRTUAL TABLE "{table}_fts" USING {fts_version} ( @@ -725,7 +725,7 @@ class Table(Queryable): self.db.conn.executescript(sql) self.populate_fts(columns) - if create_update_triggers: + if create_triggers: old_cols = ", ".join("old.[{}]".format(c) for c in columns) new_cols = ", ".join("new.[{}]".format(c) for c in columns) triggers = """ diff --git a/tests/test_cli.py b/tests/test_cli.py index 62e129b..62fc6c2 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -335,7 +335,7 @@ def test_enable_fts_with_triggers(db_path): CliRunner() .invoke( cli.cli, - ["enable-fts", db_path, "Gosh", "c1", "--fts4", "--create-update-triggers"], + ["enable-fts", db_path, "Gosh", "c1", "--fts4", "--create-triggers"], ) .exit_code ) diff --git a/tests/test_enable_fts.py b/tests/test_enable_fts.py index cb1ff7f..d8d3193 100644 --- a/tests/test_enable_fts.py +++ b/tests/test_enable_fts.py @@ -54,7 +54,7 @@ def test_enable_fts_w_triggers(fresh_db): table = fresh_db["searchable"] table.insert(search_records[0]) table.enable_fts( - ["text", "country"], fts_version="FTS4", create_update_triggers=True + ["text", "country"], fts_version="FTS4", create_triggers=True ) assert [("tanuki are tricksters", "Japan", "foo")] == table.search("tanuki") table.insert(search_records[1])