remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-29 04:14:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

db.sqlite_version property and fix for deterministic=True on SQLite 3.8.3

Browse source 
Closes #408
This commit is contained in:
Simon Willison 2022-03-01 16:24:27 -08:00
commit d25cdd37a3
4 changed files with 47 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/test_register_function.py
View file

@ -34,16 +34,31 @@ def test_register_function_deterministic(fresh_db):
@pytest.mark.skipif(
sys.version_info < (3, 8), reason="deterministic=True was added in Python 3.8"
)
def test_register_function_deterministic_registered(fresh_db):
@pytest.mark.parametrize(
"fake_sqlite_version,should_use_deterministic",
(
("3.36.0", True),
("3.8.3", True),
("3.8.2", False),
),
)
def test_register_function_deterministic_registered(
fresh_db, fake_sqlite_version, should_use_deterministic
):
fresh_db.conn = MagicMock()
fresh_db.conn.create_function = MagicMock()
fresh_db.conn.execute().fetchall.return_value = [(fake_sqlite_version,)]
@fresh_db.register_function(deterministic=True)
def to_lower_2(s):
return s.lower()
expected_kwargs = {}
if should_use_deterministic:
expected_kwargs = dict(deterministic=True)
fresh_db.conn.create_function.assert_called_with(
"to_lower_2", 1, to_lower_2, deterministic=True
"to_lower_2", 1, to_lower_2, **expected_kwargs
)