remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-23 09:24:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

upsert() now requires a value for every primary key column

Browse source 
A record missing a primary key value - or with None for one - can
never match an existing row, because a NULL primary key never
satisfies ON CONFLICT. Such records were previously inserted as
brand new rows (silently, for multi-record upsert_all calls) or
triggered a KeyError after the insert had already happened. Both
cases, including upserting an empty record, now raise
PrimaryKeyRequired before any SQL is executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UnLnhsH25Nnv7LHhekUfPd
This commit is contained in:
Claude 2026-07-04 18:43:37 +00:00
commit d6753a9f57
No known key found for this signature in database
4 changed files with 64 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
sqlite_utils/db.py
View file

@ -3199,6 +3199,11 @@ class Table(Queryable):
# Dict-mode insert({}) has no explicit columns; SQLite spells that as
# DEFAULT VALUES. List mode with no columns is a different input shape.
if not list_mode and not all_columns:
if upsert:
raise PrimaryKeyRequired(
"upsert() requires a value for the primary key - "
"an empty record cannot be upserted"
)
or_clause = ""
if replace:
or_clause = " OR REPLACE"
@ -3286,6 +3291,26 @@ class Table(Queryable):
# Everything from here on is for upsert=True
pk_cols = [pk] if isinstance(pk, str) else list(pk)
# Every record must provide a value for every primary key column - a
# NULL primary key never matches ON CONFLICT, so the record would be
# inserted as a brand new row instead of upserted
missing_pk_cols = [c for c in pk_cols if c not in all_columns]
if missing_pk_cols:
raise PrimaryKeyRequired(
"upsert() requires a value for the primary key column{}: {}".format(
"s" if len(missing_pk_cols) > 1 else "",
", ".join(missing_pk_cols),
)
)
pk_indexes = [all_columns.index(c) for c in pk_cols]
for record_values in values:
if any(record_values[i] is None for i in pk_indexes):
raise PrimaryKeyRequired(
"upsert() requires a value for the primary key column{}: {}".format(
"s" if len(pk_cols) > 1 else "",
", ".join(pk_cols),
)
)
non_pk_cols = [c for c in all_columns if c not in pk_cols]
conflict_sql = ", ".join(quote_identifier(c) for c in pk_cols)