remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-26 02:44:33 +02:00
Code Issues Projects Releases Packages Wiki Activity

Better error message if rows_from_file called with StringIO, closes #520

Browse source 
Refs #448
This commit is contained in:
Simon Willison 2023-05-08 15:08:02 -07:00
commit dab23884ae
2 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
sqlite_utils/utils.py
View file

@ -303,7 +303,13 @@ def rows_from_file(
elif format is None:
# Detect the format, then call this recursively
buffered = io.BufferedReader(cast(io.RawIOBase, fp), buffer_size=4096)
first_bytes = buffered.peek(2048).strip()
try:
first_bytes = buffered.peek(2048).strip()
except AttributeError:
# Likely the user passed a TextIO when this needs a BytesIO
raise TypeError(
"rows_from_file() requires a file-like object that supports peek(), such as io.BytesIO"
)
if first_bytes.startswith(b"[") or first_bytes.startswith(b"{"):
# TODO: Detect newline-JSON
return rows_from_file(buffered, format=Format.JSON)