remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-24 09:54:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

Better error message if rows_from_file called with StringIO, closes #520

Browse source 
Refs #448
This commit is contained in:
Simon Willison 2023-05-08 15:08:02 -07:00
commit dab23884ae
2 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/test_rows_from_file.py
View file

@ -1,5 +1,5 @@
from sqlite_utils.utils import rows_from_file, Format, RowError
from io import BytesIO
from io import BytesIO, StringIO
import pytest
@ -44,3 +44,11 @@ def test_rows_from_file_extra_fields_strategies(ignore_extras, extras_key, expec
# We did not expect an error
raise
assert list_rows == expected
def test_rows_from_file_error_on_string_io():
with pytest.raises(TypeError) as ex:
rows_from_file(StringIO("id,name\r\n1,Cleo"))
assert ex.value.args == (
"rows_from_file() requires a file-like object that supports peek(), such as io.BytesIO",
)