remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-24 18:04:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

Strip NUL bytes from CSV input to prevent crash

Browse source 
When a CSV file contains NUL bytes the csv module raises
_csv.Error: line contains NUL, crashing the insert command without a
useful error message. Stripping \x00 from each line before passing it
to the reader preserves all meaningful data while matching the
behaviour users expect. Fixes #582.
This commit is contained in:
ikatyal2110 2026-07-17 14:35:13 +00:00
commit e1d0fba30f
No known key found for this signature in database
2 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/test_cli_insert.py
View file

@ -252,6 +252,23 @@ def test_insert_csv_empty_null(db_path, empty_null):
]
def test_insert_csv_nul_bytes(db_path, tmpdir):
# Regression test for https://github.com/simonw/sqlite-utils/issues/582
# CSV files containing NUL bytes should be imported without crashing.
file_path = str(tmpdir / "nul.csv")
with open(file_path, "wb") as fp:
fp.write(b"id,name\n1,Al\x00ice\n2,Bob\n")
result = CliRunner().invoke(
cli.cli,
["insert", db_path, "data", file_path, "--csv", "--no-detect-types"],
catch_exceptions=False,
)
assert result.exit_code == 0
db = Database(db_path)
rows = list(db["data"].rows)
assert rows == [{"id": "1", "name": "Alice"}, {"id": "2", "name": "Bob"}]
@pytest.mark.parametrize(
"input,args",
(