remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-07-23 09:24:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove the no-op -d/--detect-types flag from insert and upsert

Browse source 
Type detection has been the default for CSV/TSV data since 4.0a1,
making this flag a no-op kept only for backwards compatibility.
4.0 is the release where it can be removed - the flag now errors,
prompting scripts to drop it. --no-detect-types is unchanged. The
dead detect_types parameter has been removed from
insert_upsert_implementation.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UnLnhsH25Nnv7LHhekUfPd
This commit is contained in:
Claude 2026-07-04 19:15:31 +00:00
commit f1cdceaca9
No known key found for this signature in database
4 changed files with 22 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

14
sqlite_utils/cli.py
View file

@ -940,12 +940,6 @@ def insert_upsert_options(*, require_pk=False):
type=(str, str),
help="Default value that should be set for a column",
),
click.option(
"-d",
"--detect-types",
is_flag=True,
help="Detect types for columns in CSV/TSV data (default)",
),
click.option(
"--no-detect-types",
is_flag=True,
@ -1000,7 +994,6 @@ def insert_upsert_implementation(
truncate=False,
not_null=None,
default=None,
detect_types=None,
no_detect_types=False,
analyze=False,
load_extension=None,
@ -1067,7 +1060,7 @@ def insert_upsert_implementation(
)
else:
docs = (dict(zip(headers, row)) for row in reader)
# detect_types is now the default, unless --no-detect-types is passed
# Type detection is the default, unless --no-detect-types is passed
if not no_detect_types:
tracker = TypeTracker()
docs = tracker.wrap(docs)
@ -1241,7 +1234,6 @@ def insert(
batch_size,
stop_after,
alter,
detect_types,
no_detect_types,
analyze,
load_extension,
@ -1324,7 +1316,6 @@ def insert(
ignore=ignore,
replace=replace,
truncate=truncate,
detect_types=detect_types,
no_detect_types=no_detect_types,
analyze=analyze,
load_extension=load_extension,
@ -1363,7 +1354,6 @@ def upsert(
alter,
not_null,
default,
detect_types,
no_detect_types,
analyze,
load_extension,
@ -1409,7 +1399,6 @@ def upsert(
upsert=True,
not_null=not_null,
default=default,
detect_types=detect_types,
no_detect_types=no_detect_types,
analyze=analyze,
load_extension=load_extension,
@ -1497,7 +1486,6 @@ def bulk(
upsert=False,
not_null=set(),
default={},
detect_types=False,
no_detect_types=True,
load_extension=load_extension,
silent=False,