remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-10-29 14:37:44 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge 9e64607012 into 9c66bafa52

Browse source
This commit is contained in:
Rami Abdelrazzaq 2026-10-20 04:38:57 +00:00 • committed by GitHub
commit f6cc2d0e77
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
sqlite_utils/recipes.py
View file

@ -31,7 +31,7 @@ def parsedate(
.date() .date()
.isoformat() .isoformat()
) )
except parser.ParserError: except (parser.ParserError, OverflowError):
if errors is IGNORE: if errors is IGNORE:
return value return value
elif errors is SET_NULL: elif errors is SET_NULL:
@ -58,7 +58,7 @@ def parsedatetime(
return value return value
try: try:
return parser.parse(value, dayfirst=dayfirst, yearfirst=yearfirst).isoformat() return parser.parse(value, dayfirst=dayfirst, yearfirst=yearfirst).isoformat()
except parser.ParserError: except (parser.ParserError, OverflowError):
if errors is IGNORE: if errors is IGNORE:
return value return value
elif errors is SET_NULL: elif errors is SET_NULL:

24
tests/test_recipe_overflow.py Normal file
View file

@ -0,0 +1,24 @@
import pytest
from sqlite_utils import recipes
OVERFLOWING_DATE = "999999999999999999999999999999-01-01"
@pytest.mark.parametrize("fn", ("parsedate", "parsedatetime"))
def test_dateparse_overflow_raises_by_default(fn):
with pytest.raises(OverflowError):
getattr(recipes, fn)(OVERFLOWING_DATE)
@pytest.mark.parametrize("fn", ("parsedate", "parsedatetime"))
@pytest.mark.parametrize(
"errors,expected",
(
(recipes.IGNORE, OVERFLOWING_DATE),
(recipes.SET_NULL, None),
),
)
def test_dateparse_overflow_respects_errors(fn, errors, expected):
assert getattr(recipes, fn)(OVERFLOWING_DATE, errors=errors) == expected