remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-08-13 04:44:19 +02:00
Code Issues Projects Releases Packages Wiki Activity

transform() now works for tables referenced by views (#832)

Browse source 
Closes #831
This commit is contained in:
Simon Willison 2026-08-11 20:48:11 -07:00 • committed by GitHub
commit f726ea4a65
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 204 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
sqlite_utils/db.py
View file

@ -2824,17 +2824,34 @@ class Table(Queryable):
new_cols=", ".join(quote_identifier(col) for col in new_cols),
)
sqls.append(copy_sql)
# Drop (or keep) the old table
# Drop (or keep) the old table, then rename the new one into place.
# Since SQLite 3.25 ALTER TABLE ... RENAME TO rewrites references to
# the renamed table in every view definition, which fails if a view
# references the table that was just dropped - and with keep_table=
# would silently repoint views at the backup table. These renames are
# an implementation detail of transform(), so use legacy_alter_table
# to leave view definitions untouched, restoring the connection's
# current value afterwards.
legacy_alter_table_row = self.db.execute("PRAGMA legacy_alter_table").fetchone()
legacy_alter_table_was_on = bool(
legacy_alter_table_row and legacy_alter_table_row[0]
)
if keep_table:
sqls.append("PRAGMA legacy_alter_table=ON;")
sqls.append(
f"ALTER TABLE {quote_identifier(self.name)} RENAME TO {quote_identifier(keep_table)};"
)
else:
sqls.append(f"DROP TABLE {quote_identifier(self.name)};")
# Rename the new one
sqls.append("PRAGMA legacy_alter_table=ON;")
sqls.append(
f"ALTER TABLE {quote_identifier(new_table_name)} RENAME TO {quote_identifier(self.name)};"
)
sqls.append(
"PRAGMA legacy_alter_table={};".format(
"ON" if legacy_alter_table_was_on else "OFF"
)
)
# Re-add existing indexes
for index in self.indexes:
if index.origin != "pk":