remote/sqlite-utils
1
0
Fork 0
mirror of https://github.com/simonw/sqlite-utils.git synced 2026-09-20 07:24:23 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: auto-commit delete_where()

Browse source
This commit is contained in:
cloudyun888 2026-04-22 15:14:25 +08:00
commit fcbab3649d
No known key found for this signature in database
2 changed files with 18 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
sqlite_utils/db.py
View file

@ -2905,9 +2905,10 @@ class Table(Queryable):
sql = "delete from {}".format(quote_identifier(self.name)) sql = "delete from {}".format(quote_identifier(self.name))
if where is not None: if where is not None:
sql += " where " + where sql += " where " + where
self.db.execute(sql, where_args or []) with self.db.conn:
if analyze: self.db.execute(sql, where_args or [])
self.analyze() if analyze:
self.analyze()
return self return self
def update( def update(

14
tests/test_delete.py
View file

@ -1,3 +1,4 @@
from sqlite_utils import Database
def test_delete_rowid_table(fresh_db): def test_delete_rowid_table(fresh_db):
table = fresh_db["table"] table = fresh_db["table"]
table.insert({"foo": 1}).last_pk table.insert({"foo": 1}).last_pk
@ -32,6 +33,19 @@ def test_delete_where_all(fresh_db):
assert table.count == 0 assert table.count == 0
def test_delete_where_all_auto_commits(db_path):
db = Database(db_path)
table = db["table"]
table.insert_all(({"id": i} for i in range(1, 6)), pk="id")
assert table.count == 5
table.delete_where()
assert table.count == 0
reopened = Database(db_path)
assert reopened["table"].count == 0
def test_delete_where_analyze(fresh_db): def test_delete_where_analyze(fresh_db):
table = fresh_db["table"] table = fresh_db["table"]
table.insert_all(({"id": i, "i": i} for i in range(10)), pk="id") table.insert_all(({"id": i, "i": i} for i in range(10)), pk="id")