mirror of
https://github.com/simonw/sqlite-utils.git
synced 2026-10-26 02:07:09 +01:00
Reject ambiguous mapping CSV rows
This commit is contained in:
parent
436ac10a1d
commit
ffb510c56a
2 changed files with 35 additions and 11 deletions
|
|
@ -61,10 +61,7 @@ def test_rows_to_csv_file_with_mapping_row_factory():
|
|||
)
|
||||
|
||||
def dict_factory(cursor, row):
|
||||
return {
|
||||
column[0]: value
|
||||
for column, value in zip(cursor.description, row)
|
||||
}
|
||||
return {column[0]: value for column, value in zip(cursor.description, row)}
|
||||
|
||||
db.row_factory = dict_factory
|
||||
cursor = db.execute("select id, name from creatures order by id")
|
||||
|
|
@ -74,6 +71,25 @@ def test_rows_to_csv_file_with_mapping_row_factory():
|
|||
db.close()
|
||||
|
||||
|
||||
def test_rows_to_csv_file_rejects_duplicate_mapping_columns():
|
||||
db = sqlite3.connect(":memory:")
|
||||
db.execute("create table creatures (id integer, name text)")
|
||||
db.execute("insert into creatures (id, name) values (1, 'Cleo')")
|
||||
|
||||
def dict_factory(cursor, row):
|
||||
return {column[0]: value for column, value in zip(cursor.description, row)}
|
||||
|
||||
db.row_factory = dict_factory
|
||||
cursor = db.execute("select id as value, name as value from creatures")
|
||||
output = io.StringIO(newline="")
|
||||
with pytest.raises(
|
||||
ValueError, match="Mapping rows cannot represent duplicate column names"
|
||||
):
|
||||
rows_to_csv_file(cursor, output, lineterminator="\n")
|
||||
assert output.getvalue() == ""
|
||||
db.close()
|
||||
|
||||
|
||||
@pytest.mark.parametrize("header", (True, False))
|
||||
def test_rows_to_csv_file_requires_result_columns(header):
|
||||
db = sqlite3.connect(":memory:")
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue