mirror of
https://github.com/simonw/sqlite-utils.git
synced 2026-07-21 16:34:32 +02:00
2616dec795
- table.extract() and the sqlite-utils extract command now skip rows where every extracted column is null: the new foreign key column is left null and no all-null record is added to the lookup table. Rows with at least one non-null extracted column are extracted as before. - The extracts= option to insert() and friends keeps None values as null instead of creating a lookup record for them - previously each insert batch added a duplicate null row to the lookup table. - table.lookup() compares values using IS rather than = so lookup values containing None match existing rows correctly, instead of inserting a duplicate row on every call. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
117 lines
3.5 KiB
Python
117 lines
3.5 KiB
Python
from sqlite_utils.db import Index
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"kwargs,expected_table",
|
|
[
|
|
(dict(extracts={"species_id": "Species"}), "Species"),
|
|
(dict(extracts=["species_id"]), "species_id"),
|
|
(dict(extracts=("species_id",)), "species_id"),
|
|
],
|
|
)
|
|
@pytest.mark.parametrize("use_table_factory", [True, False])
|
|
def test_extracts(fresh_db, kwargs, expected_table, use_table_factory):
|
|
table_kwargs = {}
|
|
insert_kwargs = {}
|
|
if use_table_factory:
|
|
table_kwargs = kwargs
|
|
else:
|
|
insert_kwargs = kwargs
|
|
trees = fresh_db.table("Trees", **table_kwargs)
|
|
trees.insert_all(
|
|
[
|
|
{"id": 1, "species_id": "Oak"},
|
|
{"id": 2, "species_id": "Oak"},
|
|
{"id": 3, "species_id": "Palm"},
|
|
],
|
|
**insert_kwargs,
|
|
)
|
|
# Should now have two tables: Trees and Species
|
|
assert {expected_table, "Trees"} == set(fresh_db.table_names())
|
|
assert (
|
|
'CREATE TABLE "{}" (\n "id" INTEGER PRIMARY KEY,\n "value" TEXT\n)'.format(
|
|
expected_table
|
|
)
|
|
== fresh_db[expected_table].schema
|
|
)
|
|
assert (
|
|
'CREATE TABLE "Trees" (\n "id" INTEGER,\n "species_id" INTEGER REFERENCES "{}"("id")\n)'.format(
|
|
expected_table
|
|
)
|
|
== fresh_db["Trees"].schema
|
|
)
|
|
# Should have a foreign key reference
|
|
assert len(fresh_db["Trees"].foreign_keys) == 1
|
|
fk = fresh_db["Trees"].foreign_keys[0]
|
|
assert fk.table == "Trees"
|
|
assert fk.column == "species_id"
|
|
|
|
# Should have unique index on Species
|
|
assert [
|
|
Index(
|
|
seq=0,
|
|
name="idx_{}_value".format(expected_table),
|
|
unique=1,
|
|
origin="c",
|
|
partial=0,
|
|
columns=["value"],
|
|
)
|
|
] == fresh_db[expected_table].indexes
|
|
# Finally, check the rows
|
|
assert [{"id": 1, "value": "Oak"}, {"id": 2, "value": "Palm"}] == list(
|
|
fresh_db[expected_table].rows
|
|
)
|
|
assert [
|
|
{"id": 1, "species_id": 1},
|
|
{"id": 2, "species_id": 1},
|
|
{"id": 3, "species_id": 2},
|
|
] == list(fresh_db["Trees"].rows)
|
|
|
|
|
|
def test_extracts_null_values(fresh_db):
|
|
# https://github.com/simonw/sqlite-utils/issues/186
|
|
# Null values should stay null, not be extracted into the lookup table
|
|
fresh_db["Trees"].insert_all(
|
|
[
|
|
{"id": 1, "species_id": "Oak"},
|
|
{"id": 2, "species_id": None},
|
|
{"id": 3, "species_id": "Palm"},
|
|
{"id": 4, "species_id": None},
|
|
],
|
|
extracts={"species_id": "Species"},
|
|
)
|
|
assert list(fresh_db["Species"].rows) == [
|
|
{"id": 1, "value": "Oak"},
|
|
{"id": 2, "value": "Palm"},
|
|
]
|
|
assert list(fresh_db["Trees"].rows) == [
|
|
{"id": 1, "species_id": 1},
|
|
{"id": 2, "species_id": None},
|
|
{"id": 3, "species_id": 2},
|
|
{"id": 4, "species_id": None},
|
|
]
|
|
|
|
|
|
def test_extracts_null_values_list_mode(fresh_db):
|
|
# Same as test_extracts_null_values but for list-based records
|
|
fresh_db["Trees"].insert_all(
|
|
[
|
|
["id", "species_id"],
|
|
[1, "Oak"],
|
|
[2, None],
|
|
[3, "Palm"],
|
|
[4, None],
|
|
],
|
|
extracts={"species_id": "Species"},
|
|
)
|
|
assert list(fresh_db["Species"].rows) == [
|
|
{"id": 1, "value": "Oak"},
|
|
{"id": 2, "value": "Palm"},
|
|
]
|
|
assert list(fresh_db["Trees"].rows) == [
|
|
{"id": 1, "species_id": 1},
|
|
{"id": 2, "species_id": None},
|
|
{"id": 3, "species_id": 2},
|
|
{"id": 4, "species_id": None},
|
|
]
|