mirror of
https://github.com/simonw/sqlite-utils.git
synced 2026-07-23 09:24:31 +02:00
a2e6ea2ecaUser-facing argument validation in db.py previously used bare assert statements, which vanish entirely under python -O and raise AssertionError - an exception type callers should not have to catch for input validation. Fifteen validation sites now raise ValueError with the same messages. Internal invariants (an unreachable branch and a post-update rowcount check) remain asserts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UnLnhsH25Nnv7LHhekUfPd
38 lines
1.1 KiB
Python
38 lines
1.1 KiB
Python
from sqlite_utils import Database
|
|
import sqlite3
|
|
import pathlib
|
|
import pytest
|
|
|
|
|
|
def test_recreate_ignored_for_in_memory():
|
|
# None of these should raise an exception:
|
|
Database(memory=True, recreate=False)
|
|
Database(memory=True, recreate=True)
|
|
Database(":memory:", recreate=False)
|
|
Database(":memory:", recreate=True)
|
|
|
|
|
|
def test_recreate_not_allowed_for_connection():
|
|
conn = sqlite3.connect(":memory:")
|
|
try:
|
|
with pytest.raises(ValueError):
|
|
Database(conn, recreate=True)
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"use_path,create_file_first",
|
|
[(True, True), (True, False), (False, True), (False, False)],
|
|
)
|
|
def test_recreate(tmp_path, use_path, create_file_first):
|
|
filepath = str(tmp_path / "data.db")
|
|
if use_path:
|
|
filepath = pathlib.Path(filepath)
|
|
if create_file_first:
|
|
db = Database(filepath)
|
|
db["t1"].insert({"foo": "bar"})
|
|
assert ["t1"] == db.table_names()
|
|
db.close()
|
|
Database(filepath, recreate=True)["t2"].insert({"foo": "bar"})
|
|
assert ["t2"] == Database(filepath).table_names()
|