From 3f91165f094228b061150fc587816457e619aef1 Mon Sep 17 00:00:00 2001
From: Simon Conseil <contact@saimon.org>
Date: Tue, 21 May 2013 17:15:56 +0200
Subject: [PATCH] Ensure that markup is a tuple.

`self.markup` is a list when using the `-m|--markup` cli option, but testing the
extension with `endswith` works only with tuples.
---
 pelican/generators.py            |  2 +-
 pelican/tests/test_generators.py | 26 ++++++++++++++++++++++----
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/pelican/generators.py b/pelican/generators.py
index f2fa0e33..94c425f9 100644
--- a/pelican/generators.py
+++ b/pelican/generators.py
@@ -96,7 +96,7 @@ class Generator(object):
             extensions are allowed)
         """
         if extensions is None:
-            extensions = self.markup
+            extensions = tuple(self.markup)
         basename = os.path.basename(path)
         if extensions is False or basename.endswith(extensions):
             return True
diff --git a/pelican/tests/test_generators.py b/pelican/tests/test_generators.py
index fa57322d..8922a8eb 100644
--- a/pelican/tests/test_generators.py
+++ b/pelican/tests/test_generators.py
@@ -1,14 +1,13 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals, print_function
 
-from mock import MagicMock
 import os
-
 from codecs import open
-from tempfile import mkdtemp
+from mock import MagicMock
 from shutil import rmtree
+from tempfile import mkdtemp
 
-from pelican.generators import (ArticlesGenerator, PagesGenerator,
+from pelican.generators import (Generator, ArticlesGenerator, PagesGenerator,
                                 TemplatePagesGenerator)
 from pelican.writers import Writer
 from pelican.settings import _DEFAULT_CONFIG
@@ -17,6 +16,25 @@ from pelican.tests.support import unittest, get_settings
 CUR_DIR = os.path.dirname(__file__)
 
 
+class TestGenerator(unittest.TestCase):
+    def setUp(self):
+        self.settings = get_settings()
+        self.generator = Generator(self.settings.copy(), self.settings,
+                                   CUR_DIR, self.settings['THEME'], None,
+                                   self.settings['MARKUP'])
+
+    def test_include_path(self):
+        filename = os.path.join(CUR_DIR, 'content', 'article.rst')
+        include_path = self.generator._include_path
+        self.assertTrue(include_path(filename))
+        self.assertTrue(include_path(filename, extensions=('rst',)))
+        self.assertFalse(include_path(filename, extensions=('md',)))
+
+        # markup must be a tuple, test that this works also with a list
+        self.generator.markup = ['rst', 'md']
+        self.assertTrue(include_path(filename))
+
+
 class TestArticlesGenerator(unittest.TestCase):
 
     def setUp(self):