From 67472298cad757630d04e014b06e83e9039f23fb Mon Sep 17 00:00:00 2001 From: Martin Brochhaus Date: Mon, 20 Feb 2012 17:58:23 +0100 Subject: [PATCH] Added changes as per codereview. --- .gitignore | 1 - docs/contribute.rst | 2 +- pelican/contents.py | 2 +- tests/test_contents.py | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index d033f268..5bb92c09 100644 --- a/.gitignore +++ b/.gitignore @@ -8,5 +8,4 @@ build dist output tags -.ropeproject .tox diff --git a/docs/contribute.rst b/docs/contribute.rst index aaef008b..0aaa5771 100644 --- a/docs/contribute.rst +++ b/docs/contribute.rst @@ -25,7 +25,7 @@ To create the virtualenv environment, you have to do:: Then you would have to install all the dependencies:: $ pip install -r dev_requirements.txt - $ pyhthon setup.py develop + $ python setup.py develop Running the test suite ====================== diff --git a/pelican/contents.py b/pelican/contents.py index 54227f0c..2d46add1 100644 --- a/pelican/contents.py +++ b/pelican/contents.py @@ -14,7 +14,7 @@ class Page(object): """ mandatory_properties = ('title',) - def __init__(self, content=None, metadata=None, settings=None, + def __init__(self, content, metadata=None, settings=None, filename=None): # init parameters if not metadata: diff --git a/tests/test_contents.py b/tests/test_contents.py index 4e58ec31..8cd5468d 100644 --- a/tests/test_contents.py +++ b/tests/test_contents.py @@ -17,7 +17,7 @@ class TestPage(TestCase): } def test_use_args(self): - """Creating a page with arguments passed to the connstructor should use + """Creating a page with arguments passed to the constructor should use them to initialise object's attributes. """