remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-06-02 15:16:59 +02:00
Code Issues Projects Releases Packages Wiki Activity

Clarify ignored write SQL operation tests

Browse source 
Split the combined ignored-operation decision test into separate internal-operation and select-statement cases.

Assert the decision reason for each case instead of checking the shared base class, so the tests document why those operations are ignored.
This commit is contained in:
Simon Willison 2026-05-28 12:06:57 -07:00
commit 17f45b884b
1 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/test_write_sql.py
View file

@ -4,23 +4,26 @@ from datasette.write_sql import (
RejectWriteSqlOperation,
RequireWriteSqlPermissions,
UnsupportedWriteSqlOperation,
WriteSqlOperationDecision,
decision_for_write_sql_operation,
)
def test_decision_for_write_sql_operation_ignores_internal_and_select_operations():
internal_decision = decision_for_write_sql_operation(
def test_decision_for_write_sql_operation_ignores_internal_operations():
decision = decision_for_write_sql_operation(
Operation("read", "schema", None, None, "main", internal=True)
)
select_decision = decision_for_write_sql_operation(
assert isinstance(decision, IgnoreWriteSqlOperation)
assert decision.reason == "internal SQLite operation"
def test_decision_for_write_sql_operation_ignores_select_statement_operations():
decision = decision_for_write_sql_operation(
Operation("select", "statement", None, None, None)
)
assert isinstance(internal_decision, IgnoreWriteSqlOperation)
assert isinstance(internal_decision, WriteSqlOperationDecision)
assert isinstance(select_decision, IgnoreWriteSqlOperation)
assert isinstance(select_decision, WriteSqlOperationDecision)
assert isinstance(decision, IgnoreWriteSqlOperation)
assert decision.reason == "select statement"
def test_decision_for_write_sql_operation_requires_table_write_permissions():