mirror of
https://github.com/simonw/datasette.git
synced 2026-05-31 06:07:05 +02:00
17f45b884b
Split the combined ignored-operation decision test into separate internal-operation and select-statement cases. Assert the decision reason for each case instead of checking the shared base class, so the tests document why those operations are ignored.
71 lines
2.3 KiB
Python
71 lines
2.3 KiB
Python
from datasette.utils.sql_analysis import Operation
|
|
from datasette.write_sql import (
|
|
IgnoreWriteSqlOperation,
|
|
RejectWriteSqlOperation,
|
|
RequireWriteSqlPermissions,
|
|
UnsupportedWriteSqlOperation,
|
|
decision_for_write_sql_operation,
|
|
)
|
|
|
|
|
|
def test_decision_for_write_sql_operation_ignores_internal_operations():
|
|
decision = decision_for_write_sql_operation(
|
|
Operation("read", "schema", None, None, "main", internal=True)
|
|
)
|
|
|
|
assert isinstance(decision, IgnoreWriteSqlOperation)
|
|
assert decision.reason == "internal SQLite operation"
|
|
|
|
|
|
def test_decision_for_write_sql_operation_ignores_select_statement_operations():
|
|
decision = decision_for_write_sql_operation(
|
|
Operation("select", "statement", None, None, None)
|
|
)
|
|
|
|
assert isinstance(decision, IgnoreWriteSqlOperation)
|
|
assert decision.reason == "select statement"
|
|
|
|
|
|
def test_decision_for_write_sql_operation_requires_table_write_permissions():
|
|
decision = decision_for_write_sql_operation(
|
|
Operation("insert", "table", "data", "dogs", None)
|
|
)
|
|
|
|
assert isinstance(decision, RequireWriteSqlPermissions)
|
|
assert [permission.action for permission in decision.permissions] == [
|
|
"insert-row",
|
|
"update-row",
|
|
"delete-row",
|
|
]
|
|
assert [str(permission.resource) for permission in decision.permissions] == [
|
|
"data/dogs",
|
|
"data/dogs",
|
|
"data/dogs",
|
|
]
|
|
|
|
|
|
def test_decision_for_write_sql_operation_rejects_vacuum():
|
|
decision = decision_for_write_sql_operation(
|
|
Operation("vacuum", "statement", None, None, None)
|
|
)
|
|
|
|
assert isinstance(decision, RejectWriteSqlOperation)
|
|
assert decision.message == "VACUUM is not allowed in user-supplied SQL"
|
|
|
|
|
|
def test_decision_for_write_sql_operation_ignores_functions():
|
|
decision = decision_for_write_sql_operation(
|
|
Operation("function", "function", None, None, None, target="upper")
|
|
)
|
|
|
|
assert isinstance(decision, IgnoreWriteSqlOperation)
|
|
assert decision.reason == "SQL function"
|
|
|
|
|
|
def test_decision_for_write_sql_operation_reports_unsupported_operations():
|
|
decision = decision_for_write_sql_operation(
|
|
Operation("unknown", "unknown", None, None, None)
|
|
)
|
|
|
|
assert isinstance(decision, UnsupportedWriteSqlOperation)
|
|
assert decision.message == "Unsupported SQL operation: unknown unknown"
|