remote/datasette
1
0
Fork 0
mirror of https://github.com/simonw/datasette.git synced 2026-07-08 16:44:34 +02:00
Code Issues Projects Releases Packages Wiki Activity

Make binary playwright test more robust

Browse source 
Failed here: https://github.com/simonw/datasette/actions/runs/28746832371/job/85239037361
This commit is contained in:
Simon Willison 2026-07-05 22:46:00 -07:00
commit 557e08c6ef
1 changed files with 11 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

25
tests/test_playwright.py
View file

@ -356,6 +356,14 @@ def binary_file_blob(datasette_server, pk):
return response.content
def wait_for_binary_control_file(binary_control, size, name=None):
binary_control.locator(
".row-edit-binary-size", has_text=f"Binary: {size} bytes"
).wait_for()
if name:
binary_control.locator(".row-edit-binary-name", has_text=name).wait_for()
def bulk_default_rows(datasette_server, **filters):
params = {
"_shape": "objects",
@ -1516,11 +1524,7 @@ def test_edit_row_binary_control_replaces_blob_from_file(page, datasette_server)
"buffer": replacement,
}
)
assert (
binary_control.locator(".row-edit-binary-size").inner_text()
== f"Binary: {len(replacement)} bytes"
)
assert "replacement.bin" in binary_control.inner_text()
wait_for_binary_control_file(binary_control, len(replacement), "replacement.bin")
dialog.locator(".row-edit-save").click()
page.locator(".row-mutation-status", has_text="Updated row 1").wait_for()
@ -1547,10 +1551,7 @@ def test_edit_row_binary_control_handles_null_blob(page, datasette_server):
"buffer": replacement,
}
)
assert (
binary_control.locator(".row-edit-binary-size").inner_text()
== f"Binary: {len(replacement)} bytes"
)
wait_for_binary_control_file(binary_control, len(replacement), "from-null.bin")
dialog.locator(".row-edit-save").click()
page.locator(".row-mutation-status", has_text="Updated row 3").wait_for()
@ -1583,11 +1584,7 @@ def test_insert_row_binary_control_accepts_pasted_file(page, datasette_server):
}""",
list(pasted),
)
assert (
binary_control.locator(".row-edit-binary-size").inner_text()
== f"Binary: {len(pasted)} bytes"
)
assert "pasted.bin" in binary_control.inner_text()
wait_for_binary_control_file(binary_control, len(pasted), "pasted.bin")
dialog.locator(".row-edit-save").click()
page.locator(".row-mutation-status", has_text="Inserted row 4").wait_for()