refactor(cli): simplify parseArtworkKind with slices.Contains

Replaces a nested loop and a manual append with slices.Contains and the
repo's slice.Map helper. Same behaviour, same error message.
This commit is contained in:
Deluan 2026-08-14 15:07:30 -04:00
commit 46a332757f

View file

@ -493,17 +493,10 @@ func refreshItems(ctx context.Context, ds model.DataStore, kind model.Kind, ids
func parseArtworkKind(s string) (model.Kind, error) {
kind, ok := model.ParseKind(s)
if ok {
for _, k := range artworkKinds {
if k == kind {
return kind, nil
}
}
}
valid := make([]string, 0, len(artworkKinds))
for _, k := range artworkKinds {
valid = append(valid, k.Prefix())
if ok && slices.Contains(artworkKinds, kind) {
return kind, nil
}
valid := slice.Map(artworkKinds, func(k model.Kind) string { return k.Prefix() })
return kind, fmt.Errorf("invalid kind %q, expected one of: %s", s, strings.Join(valid, ", "))
}