remote/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-10-12 20:37:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(lyrics): simplify test descriptions for structured lyrics

Browse source 
Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan 2026-06-19 16:41:14 -04:00
commit 4faed5bc44
1 changed files with 4 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

20
server/e2e/subsonic_lyrics_test.go
View file

@ -28,7 +28,7 @@ var _ = Describe("Lyrics endpoints", func() {
}
Describe("getLyricsBySongId (v2 structured)", func() {
DescribeTable("returns structured lyrics for embedded formats",
DescribeTable("returns structured lyrics",
func(title string, wantSynced bool, wantFirstLine, wantLang string) {
resp := doReq("getLyricsBySongId", "id", songID(title))
Expect(resp.Status).To(Equal("ok"))
@ -39,21 +39,9 @@ var _ = Describe("Lyrics endpoints", func() {
Expect(got.Line[0].Value).To(Equal(wantFirstLine))
},
// "xxx" is the ISO 639-2 code for "no language specified"
Entry("synced LRC", "Embedded Synced LRC", true, "embedded lrc line one", "xxx"),
Entry("plain text", "Embedded Plain", false, "plain embedded line one", "xxx"),
Entry("TTML", "Embedded TTML", true, "embedded ttml line", "xxx"),
)
DescribeTable("returns structured lyrics for sidecar formats",
func(title string, wantSynced bool, wantFirstLine, wantLang string) {
resp := doReq("getLyricsBySongId", "id", songID(title))
Expect(resp.Status).To(Equal("ok"))
got := firstLyric(resp.LyricsList)
Expect(got.Synced).To(Equal(wantSynced))
Expect(got.Lang).To(Equal(wantLang))
Expect(got.Line).ToNot(BeEmpty())
Expect(got.Line[0].Value).To(Equal(wantFirstLine))
},
Entry("synced LRC embedded", "Embedded Synced LRC", true, "embedded lrc line one", "xxx"),
Entry("plain text embedded", "Embedded Plain", false, "plain embedded line one", "xxx"),
Entry("TTML embedded", "Embedded TTML", true, "embedded ttml line", "xxx"),
Entry("LRC sidecar", "Sidecar LRC", true, "sidecar lrc line", "xxx"),
Entry("SRT sidecar", "Sidecar SRT", true, "sidecar srt line", "xxx"),
// YAML sidecar fixture sets "language: eng"; verify Navidrome passes it through unchanged.